Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(match2): Widgetify dota2's match summary #4914

Merged
merged 18 commits into from
Oct 22, 2024
Merged

refactor(match2): Widgetify dota2's match summary #4914

merged 18 commits into from
Oct 22, 2024

Conversation

Rathoz
Copy link
Collaborator

@Rathoz Rathoz commented Oct 18, 2024 •
edited
Loading

Summary

Widgetify dota2's match summary (as a preparation for the rest)

Also moved the h2h link creation logic to MGI over MS.

How did you test this change?

dev

@Rathoz Rathoz requested a review from hjpalpha October 21, 2024 12:28
@Rathoz Rathoz changed the title refactor(match2): match summary body to widget refactor(match2): Widgetify dota2's match summary (as a preparation for the rest) Oct 21, 2024
@Rathoz Rathoz changed the title refactor(match2): Widgetify dota2's match summary (as a preparation for the rest) refactor(match2): Widgetify dota2's match summary Oct 21, 2024
hjpalpha
hjpalpha reviewed Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right after deploy you will have to purge all pages that have/had match.extradata.headtohead set
else you might get it missing for Displays via ShowBracket template

@Rathoz Rathoz marked this pull request as ready for review October 22, 2024 07:12
@Rathoz Rathoz requested a review from hjpalpha October 22, 2024 07:14
@Rathoz Rathoz mentioned this pull request Oct 22, 2024
Merged
@Rathoz Rathoz merged commit 6e8ee1c into main Oct 22, 2024
5 checks passed
@Rathoz Rathoz deleted the matchsummary-body-to-widget branch October 22, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjpalpha hjpalpha hjpalpha approved these changes

Assignees
No one assigned
Labels
c: match2 g: dota2 DOTA2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rathoz @hjpalpha